Chore: don't make Linter a subclass of EventEmitter (refs #9161)

eslint · Aug 28, 2017 · fe69014 · fe69014
1 parent a8a817e
commit fe69014
Showing 1 changed file with 7 additions and 10 deletions.
diff --git a/lib/linter.js b/lib/linter.js
@@ -693,10 +693,9 @@ function parse(text, config, filePath, messages) {
  * Object that is responsible for verifying JavaScript text
  * @name eslint
  */
-class Linter extends EventEmitter {
+class Linter {
 
     constructor() {
-        super();
         this.messages = [];
         this.currentConfig = null;
         this.currentScopes = null;
@@ -709,17 +708,13 @@ class Linter extends EventEmitter {
 
         this.rules = new Rules();
         this.environments = new Environments();
-
-        // set unlimited listeners (see https://github.com/eslint/eslint/issues/524)
-        this.setMaxListeners(0);
     }
 
     /**
      * Resets the internal state of the object.
      * @returns {void}
      */
     reset() {
-        this.removeAllListeners();
         this.messages = [];
         this.currentConfig = null;
         this.currentScopes = null;
@@ -821,6 +816,10 @@ class Linter extends EventEmitter {
             ast = this.sourceCode.ast;
         }
 
+        const emitter = new EventEmitter();
+
+        emitter.setMaxListeners(Infinity);
+
         // if espree failed to parse the file, there's no sense in setting up rules
         if (ast) {
 
@@ -865,7 +864,7 @@ class Linter extends EventEmitter {
 
                     // add all the selectors from the rule as listeners
                     Object.keys(rule).forEach(selector => {
-                        this.on(selector, timing.enabled
+                        emitter.on(selector, timing.enabled
                             ? timing.time(key, rule[selector])
                             : rule[selector]
                         );
@@ -898,9 +897,7 @@ class Linter extends EventEmitter {
             // augment global scope with declared global variables
             addDeclaredGlobals(ast, this.currentScopes[0], this.currentConfig, this.environments);
 
-            let eventGenerator = new NodeEventGenerator(this);
-
-            eventGenerator = new CodePathAnalyzer(eventGenerator);
+            const eventGenerator = new CodePathAnalyzer(new NodeEventGenerator(emitter));
 
             /*
              * Each node has a type property. Whenever a particular type of