Breaking: Remove array-callback-return from recommended (fixes #8428) (…

…#8433)
eslint · Apr 13, 2017 · fac5389 · fac5389
1 parent 288c96c
commit fac5389
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/conf/eslint-recommended.js b/conf/eslint-recommended.js
@@ -17,7 +17,7 @@ module.exports = {
         /* eslint-enable sort-keys */
         "accessor-pairs": "off",
         "array-bracket-spacing": "off",
-        "array-callback-return": "error",
+        "array-callback-return": "off",
         "arrow-body-style": "off",
         "arrow-parens": "off",
         "arrow-spacing": "off",

diff --git a/docs/user-guide/migrating-to-4.0.0.md b/docs/user-guide/migrating-to-4.0.0.md
@@ -32,9 +32,8 @@ The lists below are ordered roughly by the number of users each change is expect
 
 ## <a name="eslint-recommended-changes"/> `eslint:recommended` changes
 
-Three new rules have been added to the [`eslint:recommended`](http://eslint.org/docs/user-guide/configuring#using-eslintrecommended) config:
+Two new rules have been added to the [`eslint:recommended`](http://eslint.org/docs/user-guide/configuring#using-eslintrecommended) config:
 
-* [`array-callback-return`](/docs/rules/array-callback-return) requires predicate functions to return a value when using functional patterns such as `map` and `filter`.
 * [`no-compare-neg-zero`](/docs/rules/no-compare-neg-zero) disallows comparisons to `-0`
 * [`no-useless-escape`](/docs/rules/no-useless-escape) disallows uselessly-escaped characters in strings and regular expressions
 
@@ -45,7 +44,6 @@ Three new rules have been added to the [`eslint:recommended`](http://eslint.org/
   "extends": "eslint:recommended",
 
   "rules": {
-    "array-callback-return": "off",
     "no-compare-neg-zero": "off",
     "no-useless-escape": "off"
   }

diff --git a/lib/rules/array-callback-return.js b/lib/rules/array-callback-return.js
@@ -138,7 +138,7 @@ module.exports = {
         docs: {
             description: "enforce `return` statements in callbacks of array methods",
             category: "Best Practices",
-            recommended: true
+            recommended: false
         },
 
         schema: []