Update: fix quotes false negative for string literals as template tags (

#8107)
eslint · Feb 20, 2017 · d89d0b4 · d89d0b4
1 parent 21be366
commit d89d0b4
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/lib/rules/quotes.js b/lib/rules/quotes.js
@@ -257,7 +257,11 @@ module.exports = {
             TemplateLiteral(node) {
 
                 // If backticks are expected or it's a tagged template, then this shouldn't throw an errors
-                if (allowTemplateLiterals || quoteOption === "backtick" || node.parent.type === "TaggedTemplateExpression") {
+                if (
+                    allowTemplateLiterals ||
+                    quoteOption === "backtick" ||
+                    node.parent.type === "TaggedTemplateExpression" && node === node.parent.quasi
+                ) {
                     return;
                 }
 

diff --git a/tests/lib/rules/quotes.js b/tests/lib/rules/quotes.js
@@ -302,6 +302,12 @@ ruleTester.run("quotes", rule, {
             output: "var foo = \"foo\\\\\\\nbar\";",
             parserOptions: { ecmaVersion: 6 },
             errors: [{ message: "Strings must use doublequote.", type: "TemplateLiteral" }]
+        },
+        {
+            code: "````",
+            output: "\"\"``",
+            parserOptions: { ecmaVersion: 6 },
+            errors: [{ message: "Strings must use doublequote.", type: "TemplateLiteral", line: 1, column: 1 }]
         }
     ]
 });