Fix: no-useless-return stack overflow on unreachable loops (fixes #7583…

…) (#7584)
eslint · Nov 14, 2016 · c4dd015 · c4dd015
1 parent dbff37a
commit c4dd015
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/lib/rules/no-useless-return.js b/lib/rules/no-useless-return.js
@@ -107,6 +107,7 @@ module.exports = {
 
     create(context) {
         const segmentInfoMap = new WeakMap();
+        const usedUnreachableSegments = new WeakSet();
         let scopeInfo = null;
 
         /**
@@ -175,8 +176,10 @@ module.exports = {
          */
         function markReturnStatementsOnSegmentAsUsed(segment) {
             if (!segment.reachable) {
+                usedUnreachableSegments.add(segment);
                 segment.allPrevSegments
                     .filter(isReturned)
+                    .filter(prevSegment => !usedUnreachableSegments.has(prevSegment))
                     .forEach(markReturnStatementsOnSegmentAsUsed);
                 return;
             }

diff --git a/tests/lib/rules/no-useless-return.js b/tests/lib/rules/no-useless-return.js
@@ -148,6 +148,15 @@ ruleTester.run("no-useless-return", rule, {
             else return;
             return 5;
           }
+        `,
+
+        // https://github.com/eslint/eslint/issues/7583
+        `
+          function foo() {
+            return;
+            while (foo) return;
+            foo;
+          }
         `
     ],