Fix: sort-keys ignores destructuring patterns (fixes #6896) (#6899)

eslint · Aug 13, 2016 · b9b3446 · b9b3446
1 parent 3fe3a4f
commit b9b3446
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/lib/rules/sort-keys.js b/lib/rules/sort-keys.js
@@ -124,6 +124,10 @@ module.exports = {
             },
 
             Property(node) {
+                if (node.parent.type === "ObjectPattern") {
+                    return;
+                }
+
                 const prevName = stack.prevName;
                 const thisName = getPropertyName(node);
 

diff --git a/tests/lib/rules/sort-keys.js b/tests/lib/rules/sort-keys.js
@@ -33,9 +33,12 @@ ruleTester.run("sort-keys", rule, {
         // ignore non-simple computed properties.
         {code: "var obj = {a:1, b:3, [a + b]: -1, c:2}", options: [], parserOptions: {ecmaVersion: 6}},
 
-        // ignore spred properties.
+        // ignore spread properties.
         {code: "var obj = {a:1, ...z, b:1}", options: [], parserOptions: {ecmaVersion: 6, ecmaFeatures: {experimentalObjectRestSpread: true}}},
 
+        // ignore destructuring patterns.
+        {code: "let {a, b} = {}", options: [], parserOptions: {ecmaVersion: 6}},
+
         // nested
         {code: "var obj = {a:1, b:{x:1, y:1}, c:1}", options: []},