Fix: checking right-side of default value assignment

eslint · Oct 17, 2017 · b0c134e · b0c134e
1 parent 3d0af1f
commit b0c134e
Show file tree

Hide file tree

Showing 2 changed files with 53 additions and 8 deletions.
diff --git a/lib/rules/camelcase.js b/lib/rules/camelcase.js
@@ -111,6 +111,14 @@ module.exports = {
                 // e.g.: const { no_camelcased = false } = bar;
                 } else if (node.parent.type === "Property" || node.parent.type === "AssignmentPattern") {
 
+                    if (node.parent.parent.type === "ObjectPattern") {
+                        node.parent.parent.properties.forEach(property => {
+                            if (property.value.right && property.value.right.type === "Identifier" && isUnderscored(property.value.right.name)) {
+                                report(node);
+                            }
+                        });
+                    }
+
                     // "never" check properties
                     if (properties === "never") {
                         return;

diff --git a/tests/lib/rules/camelcase.js b/tests/lib/rules/camelcase.js
@@ -82,23 +82,23 @@ ruleTester.run("camelcase", rule, {
         },
         {
             code: "const { no_camelcased } = bar;",
-            parserOptions: { ecmaVersion: 6 },
-            options: [{ properties: "never" }]
+            options: [{ properties: "never" }],
+            parserOptions: { ecmaVersion: 6 }
         },
         {
             code: "const { no_camelcased = false } = bar;",
-            parserOptions: { ecmaVersion: 6 },
-            options: [{ properties: "never" }]
+            options: [{ properties: "never" }],
+            parserOptions: { ecmaVersion: 6 }
         },
         {
             code: "function foo({ no_camelcased }) {};",
-            parserOptions: { ecmaVersion: 6 },
-            options: [{ properties: "never" }]
+            options: [{ properties: "never" }],
+            parserOptions: { ecmaVersion: 6 }
         },
         {
             code: "function foo({ no_camelcased = 'default value' }) {};",
-            parserOptions: { ecmaVersion: 6 },
-            options: [{ properties: "never" }]
+            options: [{ properties: "never" }],
+            parserOptions: { ecmaVersion: 6 }
         },
         {
             code: "function foo({ no_camelcased: camelCased }) {};",
@@ -355,6 +355,43 @@ ruleTester.run("camelcase", rule, {
                     type: "Identifier"
                 }
             ]
+        },
+        {
+            code: " const no_camelcased = 0; function foo({ camelcased_value = no_camelcased}) {}",
+            options: [{ properties: "never" }],
+            parserOptions: { ecmaVersion: 6 },
+            errors: [
+                {
+                    message: "Identifier 'no_camelcased' is not in camel case.",
+                    type: "Identifier"
+                },
+                {
+                    message: "Identifier 'camelcased_value' is not in camel case.",
+                    type: "Identifier"
+                }
+            ]
+        },
+        {
+            code: "const { bar: no_camelcased } = foo;",
+            options: [{ properties: "always" }],
+            parserOptions: { ecmaVersion: 6 },
+            errors: [
+                {
+                    message: "Identifier 'no_camelcased' is not in camel case.",
+                    type: "Identifier"
+                }
+            ]
+        },
+        {
+            code: "function foo({ value_1: my_default }) {}",
+            options: [{ properties: "always" }],
+            parserOptions: { ecmaVersion: 6 },
+            errors: [
+                {
+                    message: "Identifier 'my_default' is not in camel case.",
+                    type: "Identifier"
+                }
+            ]
         }
     ]
 });