Skip to content

Commit

Permalink
Fix: invalid tests with super (fixes #9539) (#9545)
Browse files Browse the repository at this point in the history 
This corrects some tests which used `super` in an invalid way, and are
now failing due to an acorn upgrade.
  • Loading branch information
@not-an-aardvark
not-an-aardvark committed Oct 30, 2017
1 parent 8e1a095 commit a9606a3
Show file tree
Hide file tree
Showing 2 changed files with 29 additions and 29 deletions.
2 changes: 1 addition & 1 deletion tests/lib/rules/indent.js
View file
Expand Up @@ -4351,7 +4351,7 @@ ruleTester.run("indent", rule, {
<span>
{condition ?
<Thing
foo={super}
foo={bar}
/> :
<Thing/>
}
Expand Down
56 changes: 28 additions & 28 deletions tests/lib/rules/keyword-spacing.js
View file
Expand Up @@ -928,62 +928,62 @@ ruleTester.run("keyword-spacing", rule, {
// super
//----------------------------------------------------------------------

{ code: "class A { a() { {} super[b]; } }", parserOptions: { ecmaVersion: 6 } },
{ code: "class A { a() { {}super[b]; } }", options: [NEITHER], parserOptions: { ecmaVersion: 6 } },
{ code: "class A { a() { {} super[b]; } }", options: [override("super", BOTH)], parserOptions: { ecmaVersion: 6 } },
{ code: "class A { a() { {}super[b]; } }", options: [override("super", NEITHER)], parserOptions: { ecmaVersion: 6 } },
{ code: "class A { a() { {} super[b](); } }", parserOptions: { ecmaVersion: 6 } },
{ code: "class A { a() { {}super[b](); } }", options: [NEITHER], parserOptions: { ecmaVersion: 6 } },
{ code: "class A { a() { {} super[b](); } }", options: [override("super", BOTH)], parserOptions: { ecmaVersion: 6 } },
{ code: "class A { a() { {}super[b](); } }", options: [override("super", NEITHER)], parserOptions: { ecmaVersion: 6 } },

// not conflict with `array-bracket-spacing`
{ code: "class A { a() { [super]; } }", parserOptions: { ecmaVersion: 6 } },
{ code: "class A { a() { [ super ]; } }", options: [NEITHER], parserOptions: { ecmaVersion: 6 } },
{ code: "class A { a() { [super()]; } }", parserOptions: { ecmaVersion: 6 } },
{ code: "class A { a() { [ super() ]; } }", options: [NEITHER], parserOptions: { ecmaVersion: 6 } },

// not conflict with `arrow-spacing`
{ code: "class A { a() { () =>super; } }", parserOptions: { ecmaVersion: 6 } },
{ code: "class A { a() { () => super; } }", options: [NEITHER], parserOptions: { ecmaVersion: 6 } },
{ code: "class A { a() { () =>super(); } }", parserOptions: { ecmaVersion: 6 } },
{ code: "class A { a() { () => super(); } }", options: [NEITHER], parserOptions: { ecmaVersion: 6 } },

// not conflict with `block-spacing`
{ code: "class A { a() {super} }", parserOptions: { ecmaVersion: 6 } },
{ code: "class A { a() { super } }", options: [NEITHER], parserOptions: { ecmaVersion: 6 } },
{ code: "class A { a() {super()} }", parserOptions: { ecmaVersion: 6 } },
{ code: "class A { a() { super() } }", options: [NEITHER], parserOptions: { ecmaVersion: 6 } },

// not conflict with `comma-spacing`
{ code: "class A { a() { (0,super) } }", parserOptions: { ecmaVersion: 6 } },
{ code: "class A { a() { (0, super) } }", options: [NEITHER], parserOptions: { ecmaVersion: 6 } },
{ code: "class A { a() { (0,super()) } }", parserOptions: { ecmaVersion: 6 } },
{ code: "class A { a() { (0, super()) } }", options: [NEITHER], parserOptions: { ecmaVersion: 6 } },

// not conflict with `computed-property-spacing`
{ code: "class A { a() { ({[super]: 0}) } }", parserOptions: { ecmaVersion: 6 } },
{ code: "class A { a() { ({[ super ]: 0}) } }", options: [NEITHER], parserOptions: { ecmaVersion: 6 } },
{ code: "class A { a() { ({[super()]: 0}) } }", parserOptions: { ecmaVersion: 6 } },
{ code: "class A { a() { ({[ super() ]: 0}) } }", options: [NEITHER], parserOptions: { ecmaVersion: 6 } },

// not conflict with `key-spacing`
{ code: "class A { a() { ({a:super }) } }", parserOptions: { ecmaVersion: 6 } },
{ code: "class A { a() { ({a: super }) } }", options: [NEITHER], parserOptions: { ecmaVersion: 6 } },
{ code: "class A { a() { ({a:super() }) } }", parserOptions: { ecmaVersion: 6 } },
{ code: "class A { a() { ({a: super() }) } }", options: [NEITHER], parserOptions: { ecmaVersion: 6 } },

// not conflict with `func-call-spacing`
{ code: "class A { constructor() { super(); } }", parserOptions: { ecmaVersion: 6 } },
{ code: "class A { constructor() { super (); } }", options: [NEITHER], parserOptions: { ecmaVersion: 6 } },

// not conflict with `semi-spacing`
{ code: "class A { a() { ;super; } }", parserOptions: { ecmaVersion: 6 } },
{ code: "class A { a() { ; super ; } }", options: [NEITHER], parserOptions: { ecmaVersion: 6 } },
{ code: "class A { a() { ;super(); } }", parserOptions: { ecmaVersion: 6 } },
{ code: "class A { a() { ; super() ; } }", options: [NEITHER], parserOptions: { ecmaVersion: 6 } },

// not conflict with `space-in-parens`
{ code: "class A { a() { (super) } }", parserOptions: { ecmaVersion: 6 } },
{ code: "class A { a() { ( super ) } }", options: [NEITHER], parserOptions: { ecmaVersion: 6 } },
{ code: "class A { a() { (super()) } }", parserOptions: { ecmaVersion: 6 } },
{ code: "class A { a() { ( super() ) } }", options: [NEITHER], parserOptions: { ecmaVersion: 6 } },

// not conflict with `space-infix-ops`
{ code: "class A { a() { b =super } }", parserOptions: { ecmaVersion: 6 } },
{ code: "class A { a() { b = super } }", options: [NEITHER], parserOptions: { ecmaVersion: 6 } },
{ code: "class A { a() { b =super() } }", parserOptions: { ecmaVersion: 6 } },
{ code: "class A { a() { b = super() } }", options: [NEITHER], parserOptions: { ecmaVersion: 6 } },

// not conflict with `space-unary-ops`
{ code: "class A { a() { !super } }", parserOptions: { ecmaVersion: 6 } },
{ code: "class A { a() { ! super } }", options: [NEITHER], parserOptions: { ecmaVersion: 6 } },
{ code: "class A { a() { !super() } }", parserOptions: { ecmaVersion: 6 } },
{ code: "class A { a() { ! super() } }", options: [NEITHER], parserOptions: { ecmaVersion: 6 } },

// not conflict with `template-curly-spacing`
{ code: "class A { a() { `${super}` } }", parserOptions: { ecmaVersion: 6 } },
{ code: "class A { a() { `${ super }` } }", options: [NEITHER], parserOptions: { ecmaVersion: 6 } },
{ code: "class A { a() { `${super()}` } }", parserOptions: { ecmaVersion: 6 } },
{ code: "class A { a() { `${ super() }` } }", options: [NEITHER], parserOptions: { ecmaVersion: 6 } },

// not conflict with `jsx-curly-spacing`
{ code: "class A { a() { <Foo onClick={super} /> } }", parserOptions: { ecmaVersion: 6, ecmaFeatures: { jsx: true } } },
{ code: "class A { a() { <Foo onClick={ super } /> } }", options: [NEITHER], parserOptions: { ecmaVersion: 6, ecmaFeatures: { jsx: true } } },
{ code: "class A { a() { <Foo onClick={super()} /> } }", parserOptions: { ecmaVersion: 6, ecmaFeatures: { jsx: true } } },
{ code: "class A { a() { <Foo onClick={ super() } /> } }", options: [NEITHER], parserOptions: { ecmaVersion: 6, ecmaFeatures: { jsx: true } } },

//----------------------------------------------------------------------
// switch
Expand Down

0 comments on commit a9606a3

Please sign in to comment.