Fix: dot-notation autofix produces invalid syntax for integer propert…

…ies (#8332) Previously, when fixing a computed property access from a number literal, the dot-notation autofixer would place a dot immediately after the number literal. However, a dot after a decimal integer literal gets parsed as a decimal point, not a property accessor. This commit updates the fixer to insert a space before the dot when the object is a decimal integer literal.
eslint · Mar 28, 2017 · 927de90 · 927de90
1 parent a9d1bea
commit 927de90
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/lib/rules/dot-notation.js b/lib/rules/dot-notation.js
@@ -79,9 +79,11 @@ module.exports = {
                                     return null;
                                 }
 
+                                const textBeforeDot = astUtils.isDecimalInteger(node.object) ? " " : "";
+
                                 return fixer.replaceTextRange(
                                     [leftBracket.range[0], rightBracket.range[1]],
-                                    `.${node.property.value}`
+                                    `${textBeforeDot}.${node.property.value}`
                                 );
                             }
                         });

diff --git a/tests/lib/rules/dot-notation.js b/tests/lib/rules/dot-notation.js
@@ -168,6 +168,11 @@ ruleTester.run("dot-notation", rule, {
             code: "(foo)['bar']",
             output: "(foo).bar",
             errors: [{ message: "[\"bar\"] is better written in dot notation." }]
+        },
+        {
+            code: "1['toString']",
+            output: "1 .toString",
+            errors: [{ message: "[\"toString\"] is better written in dot notation." }]
         }
     ]
 });