Fix: no-useless-computed-key false positive with __proto__ (#7934)

eslint · Jan 19, 2017 · 8ac3518 · 8ac3518
1 parent c835e19
commit 8ac3518
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/lib/rules/no-useless-computed-key.js b/lib/rules/no-useless-computed-key.js
@@ -34,7 +34,7 @@ module.exports = {
                 const key = node.key,
                     nodeType = typeof key.value;
 
-                if (key.type === "Literal" && (nodeType === "string" || nodeType === "number")) {
+                if (key.type === "Literal" && (nodeType === "string" || nodeType === "number") && key.value !== "__proto__") {
                     context.report({
                         node,
                         message: MESSAGE_UNNECESSARY_COMPUTED,

diff --git a/tests/lib/rules/no-useless-computed-key.js b/tests/lib/rules/no-useless-computed-key.js
@@ -22,7 +22,8 @@ ruleTester.run("no-useless-computed-key", rule, {
     valid: [
         "({ 'a': 0, b(){} })",
         "({ [x]: 0 });",
-        "({ a: 0, [b](){} })"
+        "({ a: 0, [b](){} })",
+        "({ ['__proto__']: [] })"
     ],
     invalid: [
         {