Chore: Correct the invalid tests in no-empty-function for use with me…

…ssageIds
eslint · Sep 14, 2017 · 5d9dc42 · 5d9dc42
1 parent ca75b44
commit 5d9dc42
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/tests/lib/cli-engine.js b/tests/lib/cli-engine.js
@@ -1395,6 +1395,7 @@ describe("CLIEngine", () => {
                                     column: 9,
                                     line: 2,
                                     message: "Expected '===' and instead saw '=='.",
+                                    messageId: "unexpected",
                                     nodeType: "BinaryExpression",
                                     ruleId: "eqeqeq",
                                     severity: 2,

diff --git a/tests/lib/rules/no-empty-function.js b/tests/lib/rules/no-empty-function.js
@@ -58,10 +58,12 @@ function toValidInvalid(patterns, item) {
         }
     );
 
+    const error = item.message || { messageId: item.messageId, data: item.data };
+
     // Invalid Patterns.
     patterns.invalid.push({
         code: item.code,
-        errors: [item.message],
+        errors: [error],
         parserOptions: { ecmaVersion: 6 }
     });
     ALLOW_OPTIONS
@@ -71,7 +73,7 @@ function toValidInvalid(patterns, item) {
             // non related "allow" option has no effect.
             patterns.invalid.push({
                 code: `${item.code} // allow: ${allow}`,
-                errors: [item.message],
+                errors: [error],
                 options: [{ allow: [allow] }],
                 parserOptions: { ecmaVersion: 6 }
             });

diff --git a/tests/lib/rules/no-extra-label.js b/tests/lib/rules/no-extra-label.js
@@ -105,7 +105,7 @@ ruleTester.run("no-extra-label", rule, {
                     }
                 }
             `,
-            errors: [{ message: { messageId: "unexpected", data: { name: "A" } }, type: "Identifier", line: 2 }]
+            errors: [{ messageId: "unexpected", data: { name: "A" }, type: "Identifier", line: 2 }]
         }
     ]
 });