Fix: support else if in return-else-if

eslint · Sep 4, 2017 · 1625b0a · 1625b0a
1 parent a710c0b
commit 1625b0a
Showing 1 changed file with 2 additions and 11 deletions.
diff --git a/lib/rules/no-else-return.js b/lib/rules/no-else-return.js
@@ -197,9 +197,6 @@ module.exports = {
          */
         function IfStatement(node) {
             const parent = context.getAncestors().pop();
-            let consequents,
-                alternate;
-
             /*
              * Fixing this would require splitting one statement into two, so no error should
              * be reported if this node is in a position where only one statement is allowed.
@@ -208,15 +205,9 @@ module.exports = {
                 return;
             }
 
-            for (consequents = []; node.type === "IfStatement"; node = node.alternate) {
-                if (!node.alternate) {
-                    return;
-                }
-                consequents.push(node.consequent);
-                alternate = node.alternate;
-            }
+            const alternate = node.alternate;
 
-            if (consequents.every(alwaysReturns)) {
+            if (alternate && alwaysReturns(node.consequent)) {
                 displayReport(alternate);
             }
         }