Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Cleanup ember-environment not to mutate the picked up EmberENV global.
- Loading branch information
1 parent
90cc5c0
commit 77e033e
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,43 +1,4 @@ | ||
| import global from './global'; | ||
|
|
||
| /** | ||
| The hash of environment variables used to control various configuration | ||
|
|
@@ -50,93 +11,165 @@ export interface Environment { | |
| @type Object | ||
| @public | ||
| */ | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong. 
rwjblue
Member
|
||
| export const ENV = { | ||
| ENABLE_OPTIONAL_FEATURES: false, | ||
|
|
||
| /** | ||
| Determines whether Ember should add to `Array`, `Function`, and `String` | ||
| native object prototypes, a few extra methods in order to provide a more | ||
| friendly API. | ||
| We generally recommend leaving this option set to true however, if you need | ||
| to turn it off, you can add the configuration property | ||
| `EXTEND_PROTOTYPES` to `EmberENV` and set it to `false`. | ||
| Note, when disabled (the default configuration for Ember Addons), you will | ||
| instead have to access all methods and functions from the Ember | ||
| namespace. | ||
| @property EXTEND_PROTOTYPES | ||
| @type Boolean | ||
| @default true | ||
| @for EmberENV | ||
| @public | ||
| */ | ||
| EXTEND_PROTOTYPES: { | ||
| Array: true, | ||
| Function: true, | ||
| String: true, | ||
| }, | ||
|
|
||
| /** | ||
| The `LOG_STACKTRACE_ON_DEPRECATION` property, when true, tells Ember to log | ||
| a full stack trace during deprecation warnings. | ||
| @property LOG_STACKTRACE_ON_DEPRECATION | ||
| @type Boolean | ||
| @default true | ||
| @for EmberENV | ||
| @public | ||
| */ | ||
| LOG_STACKTRACE_ON_DEPRECATION: true, | ||
|
|
||
| /** | ||
| The `LOG_VERSION` property, when true, tells Ember to log versions of all | ||
| dependent libraries in use. | ||
| @property LOG_VERSION | ||
| @type Boolean | ||
| @default true | ||
| @for EmberENV | ||
| @public | ||
| */ | ||
| LOG_VERSION: true, | ||
|
|
||
| RAISE_ON_DEPRECATION: false, | ||
|
|
||
| /** | ||
| Whether to insert a `<div class="ember-view" />` wrapper around the | ||
| application template. See RFC #280. | ||
| This is not intended to be set directly, as the implementation may change in | ||
| the future. Use `@ember/optional-features` instead. | ||
| @property _APPLICATION_TEMPLATE_WRAPPER | ||
| @for EmberENV | ||
| @type Boolean | ||
| @default true | ||
| @private | ||
| */ | ||
| _APPLICATION_TEMPLATE_WRAPPER: true, | ||
|
|
||
| /** | ||
| Whether to use Glimmer Component semantics (as opposed to the classic "Curly" | ||
| components semantics) for template-only components. See RFC #278. | ||
| This is not intended to be set directly, as the implementation may change in | ||
| the future. Use `@ember/optional-features` instead. | ||
| @property _TEMPLATE_ONLY_GLIMMER_COMPONENTS | ||
| @for EmberENV | ||
| @type Boolean | ||
| @default false | ||
| @private | ||
| */ | ||
| _TEMPLATE_ONLY_GLIMMER_COMPONENTS: false, | ||
|
|
||
| // the following for addon support | ||
| _ENABLE_EMBER_K_SUPPORT: false, | ||
| _ENABLE_SAFE_STRING_SUPPORT: false, | ||
| _ENABLE_ENUMERABLE_CONTAINS_SUPPORT: false, | ||
| _ENABLE_UNDERSCORE_ACTIONS_SUPPORT: false, | ||
| _ENABLE_REVERSED_OBSERVER_SUPPORT: false, | ||
| _ENABLE_INITIALIZER_ARGUMENTS_SUPPORT: false, | ||
| _ENABLE_ROUTER_RESOURCE: false, | ||
| _ENABLE_CURRENT_WHEN_SUPPORT: false, | ||
| _ENABLE_CONTROLLER_WRAPPED_SUPPORT: false, | ||
| _ENABLE_DEPRECATED_REGISTRY_SUPPORT: false, | ||
| _ENABLE_IMMEDIATE_OBSERVER_SUPPORT: false, | ||
| _ENABLE_STRING_FMT_SUPPORT: false, | ||
| _ENABLE_FREEZABLE_SUPPORT: false, | ||
| _ENABLE_COMPONENT_DEFAULTLAYOUT_SUPPORT: false, | ||
| _ENABLE_BINDING_SUPPORT: false, | ||
| _ENABLE_INPUT_TRANSFORM_SUPPORT: false, | ||
| _ENABLE_DEPRECATION_OPTIONS_SUPPORT: false, | ||
| _ENABLE_ORPHANED_OUTLETS_SUPPORT: false, | ||
| _ENABLE_WARN_OPTIONS_SUPPORT: false, | ||
| _ENABLE_RESOLVER_FUNCTION_SUPPORT: false, | ||
| _ENABLE_DID_INIT_ATTRS_SUPPORT: false, | ||
| _ENABLE_RENDER_SUPPORT: false, | ||
| _ENABLE_PROPERTY_REQUIRED_SUPPORT: false, | ||
|
|
||
| EMBER_LOAD_HOOKS: {} as { | ||
| [hook: string]: Function[]; | ||
| }, | ||
| }; | ||
|
|
||
| (EmberENV => { | ||
| if (typeof EmberENV !== 'object' || EmberENV === null) return; | ||
|
|
||
| for (let flag in EmberENV) { | ||
| if ( | ||
| !EmberENV.hasOwnProperty(flag) || | ||
| flag === 'EXTEND_PROTOTYPES' || | ||
| flag === 'EMBER_LOAD_HOOKS' | ||
| ) | ||
| continue; | ||
| let defaultValue = ENV[flag]; | ||
| if (defaultValue === true) { | ||
| ENV[flag] = EmberENV[flag] !== false; | ||
| } else if (defaultValue === false) { | ||
| ENV[flag] = EmberENV[flag] === true; | ||
| } | ||
| } | ||
|
|
||
| let { EXTEND_PROTOTYPES } = EmberENV; | ||
| if (EXTEND_PROTOTYPES !== undefined) { | ||
| if (typeof EXTEND_PROTOTYPES === 'object' && EXTEND_PROTOTYPES === null) { | ||
| ENV.EXTEND_PROTOTYPES.String = EXTEND_PROTOTYPES.String !== false; | ||
| ENV.EXTEND_PROTOTYPES.Function = EXTEND_PROTOTYPES.Function !== false; | ||
| ENV.EXTEND_PROTOTYPES.Array = EXTEND_PROTOTYPES.Array !== false; | ||
| } else { | ||
| ENV.EXTEND_PROTOTYPES.String = EXTEND_PROTOTYPES !== false; | ||
| ENV.EXTEND_PROTOTYPES.Function = EXTEND_PROTOTYPES !== false; | ||
| ENV.EXTEND_PROTOTYPES.Array = EXTEND_PROTOTYPES !== false; | ||
| } | ||
| } | ||
|
|
||
| // TODO this does not seem to be used by anything, | ||
| // can we remove it? do we need to deprecate it? | ||
| let { EMBER_LOAD_HOOKS } = EmberENV; | ||
| if (typeof EMBER_LOAD_HOOKS === 'object' && EMBER_LOAD_HOOKS !== null) { | ||
| for (let hookName in EMBER_LOAD_HOOKS) { | ||
| if (!EMBER_LOAD_HOOKS.hasOwnProperty(hookName)) continue; | ||
| let hooks = EMBER_LOAD_HOOKS[hookName]; | ||
| if (Array.isArray(hooks)) { | ||
| ENV.EMBER_LOAD_HOOKS[hookName] = hooks.filter(hook => typeof hook === 'function'); | ||
| } | ||
| } | ||
| } | ||
| })(global.EmberENV || global.ENV); | ||
|
|
||
| export function getENV() { | ||
| return ENV; | ||
| } | ||
I believe doing this broke (a feature we are removing) on ember-data against ember canary. Example: https://travis-ci.org/emberjs/data/jobs/364748250
We were relying on merging feature flags, but we only have one feature flag that used ENV in this way and it is on its way out: emberjs/data#5437