Add a small configurable delay to test isolation validation assertion. #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent changes to Ember (for the `@tracked` feature in Octane) make it so that an autorun is much more commonly present. In those cases any operation using `run.join` that would have previously been sync (because no autorun existed when `run.join` was invoked) will now flush asynchronously. In this case we will only have a single autorun scheduled (which would resolve on the next microtask queue flush), but it would be enough to "trip up" the test isolation validation system. With this change to the test isolation validation infrastructure we allow a small delay for the test to "settle" before doing the assertion. This change makes it possible for many more applications and addons to take advantage of the protections that test isolation validation provides without incurring frustrating to track down timing issues outside of the applications own control.
|
Good catch. This looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent changes to Ember (for the
@trackedfeature in Octane) make it so that an autorun is much more commonly present. In those cases any operation usingrun.jointhat would have previously been sync (because no autorun existed whenrun.joinwas invoked) will now flush asynchronously. In this case we will only have a single autorun scheduled (which would resolve on the next microtask queue flush), but it would be enough to "trip up" the test isolation validation system.With this change to the test isolation validation infrastructure we allow a small delay for the test to "settle" before doing the assertion. This change makes it possible for many more applications and addons to take advantage of the protections that test isolation validation provides without incurring frustrating to track down timing issues outside of the applications own control.
Closes #478.