Skip to content

Commit

Permalink
Merge pull request #183 from jenweber/bugfix-define-property
Browse files Browse the repository at this point in the history
Bugfix: adding deprecations won't throw on multiple installed copies …
  • Loading branch information
ef4 committed Jun 10, 2019
2 parents 785c69e + e092c06 commit 0402a58
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions addon/index.js
Expand Up @@ -19,7 +19,7 @@ Object.defineProperty(Ember, 'Inflector', {

return Inflector;
},
});
}, { configurable: true });

Object.defineProperty(Ember.String, 'singularize', {
get() {
Expand All @@ -30,7 +30,7 @@ Object.defineProperty(Ember.String, 'singularize', {

return singularize;
},
});
}, { configurable: true });

Object.defineProperty(Ember.String, 'pluralize', {
get() {
Expand All @@ -41,7 +41,7 @@ Object.defineProperty(Ember.String, 'pluralize', {

return pluralize;
},
});
}, { configurable: true });

import "./lib/ext/string";

Expand Down
4 changes: 2 additions & 2 deletions addon/lib/ext/string.js
Expand Up @@ -23,7 +23,7 @@ if (Ember.ENV.EXTEND_PROTOTYPES === true || Ember.ENV.EXTEND_PROTOTYPES.String)
return pluralize(this);
};
},
});
}, { configurable: true });

/**
See {{#crossLink "Ember.String/singularize"}}{{/crossLink}}
Expand All @@ -42,5 +42,5 @@ if (Ember.ENV.EXTEND_PROTOTYPES === true || Ember.ENV.EXTEND_PROTOTYPES.String)
return singularize(this);
};
},
});
}, { configurable: true });
}

0 comments on commit 0402a58

Please sign in to comment.