[BUGFIX] update content of proxy for async belongs-to relationships when null data received #5461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fivetanley
force-pushed
the
figuring-out-nulling-relationship-by-returning-empty-payload
branch
from
d435dc9
to
98bda33
Compare
This adds a failing test that a relationship should disassociate records on both sides of the relationship when a payload explicitly returns null for the data of that relationship.
fivetanley
force-pushed
the
figuring-out-nulling-relationship-by-returning-empty-payload
branch
from
98bda33
to
741fe77
Compare
…tes content when new content is explicitly null
runspired
changed the title
runspired
deleted the
figuring-out-nulling-relationship-by-returning-empty-payload
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #5452
replaces #5457
This adds a failing test that a relationship should disassociate records
on both sides of the relationship when a payload explicitly returns null
for the data of that relationship.
'book removed from author'is the assertion that fails here. e.g. the record is not removed on the hasMany side.