[CHORE] remove all usage of Ember.copy #5436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
requested changes
Apr 16, 2018
| @@ -636,7 +632,7 @@ export default class InternalModel { | |||
| changedKeys = this._changedKeys(data.attributes); | |||
| } | |||
|
|
|||
| emberAssign(this._data, data.attributes); | |||
| Object.assign(this._data, data.attributes); | |||
There was a problem hiding this comment.
Can't rely on Object.assign. Use Ember.assign instead (IE11 does not have Object.assign)...
The prior code supported falling back to Ember.merge (supporting Ember < 2.4 IIRC) which we shouldn't need to do any longer....
runspired
commented
Apr 16, 2018
package.json
Outdated
| @@ -96,7 +96,7 @@ | |||
| "ember-publisher": "0.0.7", | |||
| "ember-qunit-assert-helpers": "^0.2.1", | |||
| "ember-resolver": "^4.1.0", | |||
| "ember-source": "~3.0.0", | |||
| "ember-source": "https://s3.amazonaws.com/builds.emberjs.com/release/shas/50db6dc8001c127e5aeb2d6ddbacf9f9205d1d7b.tgz", | |||
There was a problem hiding this comment.
o.OI think I have an uncleaned up ember-try state
fix package.json support IE11
runspired
force-pushed
the
remove-copy-usage
branch
from
51ad4f5
to
23a87e8
Compare
rwjblue
approved these changes
Apr 16, 2018
This was referenced Aug 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test utility for
deepCopywhere we needed it, usesObject.assigneverywhere else.