Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove exists-sync dependency #5432

Merged
merged 1 commit into from Apr 13, 2018

Conversation

Bartheleway
Copy link
Contributor

This should close #5431

@runspired
Copy link
Contributor

Thank you for the contribution! I'm not sure why ember beta and canary are broken. Trying to get that resolved so this will merge :)

@runspired
Copy link
Contributor

I checked into it locally and those versions of Ember fail because of this regression: emberjs/ember.js#16511

Merging the PR, thanks :)

@runspired runspired merged commit a3dd5a6 into emberjs:master Apr 13, 2018
@alex-ushakov-93
Copy link

Error creating new application. Removing generated directory `./ember-quickstart`
Command failed: npm install --loglevel error
npm WARN deprecated exists-sync@0.0.4: Please replace with usage of fs.existsSync
npm WARN deprecated exists-sync@0.0.3: Please replace with usage of fs.existsSync
npm ERR! code ERR_STREAM_WRITE_AFTER_END
npm ERR! write after end

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/alex/.npm/_logs/2018-04-13T19_20_50_816Z-debug.log

Stack Trace and Error Report: /tmp/error.dump.db4df0879d38eb40d7c085354ee5eb52.log
alex@acer:~/Desktop$ yarn info ember-cli | grep version
  versions: 
  version: '3.1.1',
alex@acer:~/Desktop$ 

?

@runspired
Copy link
Contributor

@alex-ushakov-93 This just removes a deprecation warning, it isn't an error. It looks like something else went wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated exists-sync dependency
3 participants