[FEAT] Prevent async test leakage (feat. adds test waiters) #5422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runspired
changed the title
rwjblue
approved these changes
Apr 5, 2018
bump qunit register a waiter and use a global backburner instance add test waiter for network requests cleanup leaky tests fix blueprints to account for ember-qunit update delete record does not have a return value
runspired
force-pushed
the
fix-async-leaks
branch
from
5f08343
to
5ded042
Compare
|
This looks good to me, but I do think we should work to remove a lot of this manual run-wrapping. It seems fairly archaic and likely covers some things up.... |
This was referenced Apr 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @locks because this should enable the learning team to clean up some things since more stuff is waited on by-default.