[CHORE] remove all benchmark related code #5336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failure appears to be ember canary and unrelated to this code deletion. |
|
cc @HeroicEric I think you were tasked with fixing this build issue |
|
Looks good. @runspired do you mind rebasing this pr? |
bmac
approved these changes
Feb 28, 2018
|
@bmac will get it rebased today :) |
runspired
force-pushed
the
remove-benchmark-code
branch
from
4abfce7
to
08ef8c2
Compare
|
Failures are due to master being broken against ember canary, and not this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The benchmark harness has now been extracted: https://github.com/runspired/ember-data-benchmark-suite