Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the API docs for snapshots #4638

Merged
merged 1 commit into from Jan 9, 2017
Merged

Conversation

bmac
Copy link
Member

@bmac bmac commented Nov 9, 2016

No description provided.


export default DS.Adapter.extend({
createRecord: function(store, type, snapshot) {
var data = this.serialize(snapshot, { includeId: true });
Copy link
Contributor

@sly7-7 sly7-7 Nov 10, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not use snapshot.serialize ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. I copied and pasted from the adapter docs and forgot to edit this line. Updated.

import DS from 'ember-data'

export default DS.JSONAPIAdapter.extend({
shouldReloadAll: function(store, snapshotRecordArray) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ES2015 method shorthand: shouldReloadAll(store, snapshotRecordArray) {.

import MyCustomAdapter from './custom-adapter';

export default MyCustomAdapter.extend({
findAll: function(store, type, sinceToken, snapshotRecordArray) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ES2015 method shorthand: findAll(store, type, sinceToken, snapshotRecordArray) {.

import DS from 'ember-data';

export default DS.Adapter.extend({
findAll: function(store, type, snapshotRecordArray) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ES2015 method shorthand: findAll(store, type, snapshotRecordArray) {.

import DS from 'ember-data'

export default DS.JSONAPIAdapter.extend({
shouldReloadAll: function(store, snapshotArray) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ES2015 method shorthand: shouldReloadAll(store, snapshotArray) {.

import DS from 'ember-data';

export default DS.Adapter.extend({
createRecord: function(store, type, snapshot) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ES2015 method shorthand: createRecord(store, type, snapshot) {.

@bmac
Copy link
Member Author

bmac commented Dec 6, 2016

@locks did these changes address your issues?

@locks locks self-assigned this Jan 9, 2017
@locks locks merged commit be37733 into emberjs:master Jan 9, 2017
@bmac bmac deleted the doc-snapshot branch January 9, 2017 14:34
@runspired runspired added 🏷️ doc This PR adds/improves/or fixes documentation and removed Documentation labels Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ doc This PR adds/improves/or fixes documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants