Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix no-capital-letters-in-routes so it deals with MemberExpressions #229

Merged
merged 1 commit into from Mar 21, 2018
Merged

Fix no-capital-letters-in-routes so it deals with MemberExpressions #229

merged 1 commit into from Mar 21, 2018

Conversation

nlfurniss
Copy link
Contributor

Fixes #227 and adds tests.

rwjblue
rwjblue reviewed Feb 23, 2018
View reviewed changes
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test looks good, but I'm wondering if we should instead change things around a bit and only match literals? Specifically StringLiteral and TemplateLiteral..

Thoughts?

@nlfurniss
Copy link
Contributor Author

Seems reasonable to me - updated.

@nlfurniss
Copy link
Contributor Author

@rwjblue this look g2g?

@rwjblue rwjblue merged commit 6c2202d into ember-cli:master Mar 21, 2018
@rwjblue
Copy link
Member

rwjblue commented Mar 21, 2018

Thank you @nlfurniss!

@rwjblue rwjblue added the Bug label May 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nlfurniss @rwjblue