Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Drop require-folder-tree dependency.
`require-folder-tree` is using a _very_ old `lodash` version which is flagged by an `npm audit` in consuming ember-cli applications as the following: ``` ┌───────────────┬──────────────────────────────────────────────────────────────┐ │ Low │ Prototype Pollution │ ├───────────────┼──────────────────────────────────────────────────────────────┤ │ Package │ lodash │ ├───────────────┼──────────────────────────────────────────────────────────────┤ │ Patched in │ >=4.17.5 │ ├───────────────┼──────────────────────────────────────────────────────────────┤ │ Dependency of │ eslint-plugin-ember [dev] │ ├───────────────┼──────────────────────────────────────────────────────────────┤ │ Path │ eslint-plugin-ember > require-folder-tree > lodash │ ├───────────────┼──────────────────────────────────────────────────────────────┤ │ More info │ https://nodesecurity.io/advisories/577 │ └───────────────┴──────────────────────────────────────────────────────────────┘ ``` I also personally find the explicitness here to be nicer...
- Loading branch information
Showing
3 changed files
with
37 additions
and
25 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,20 +1,43 @@ | ||
'use strict'; | ||
|
||
const resolve = require('path').resolve; | ||
const requireFolderTree = require('require-folder-tree'); | ||
|
||
const rules = requireFolderTree(resolve(__dirname, 'rules')); | ||
const configs = requireFolderTree(resolve(__dirname, 'config')); | ||
|
||
/* eslint-disable import/no-dynamic-require */ | ||
const ember = require(resolve(__dirname, 'utils/ember')); | ||
const utils = require(resolve(__dirname, 'utils/utils')); | ||
|
||
/* eslint-disable global-require */ | ||
module.exports = { | ||
rules, | ||
configs, | ||
rules: { | ||
'alias-model-in-controller': require('./rules/alias-model-in-controller'), | ||
'avoid-leaking-state-in-components': require('./rules/avoid-leaking-state-in-components'), | ||
'avoid-leaking-state-in-ember-objects': require('./rules/avoid-leaking-state-in-ember-objects'), | ||
'closure-actions': require('./rules/closure-actions'), | ||
'jquery-ember-run': require('./rules/jquery-ember-run'), | ||
'local-modules': require('./rules/local-modules'), | ||
'named-functions-in-promises': require('./rules/named-functions-in-promises'), | ||
'new-module-imports': require('./rules/new-module-imports'), | ||
'no-attrs-in-components': require('./rules/no-attrs-in-components'), | ||
'no-attrs-snapshot': require('./rules/no-attrs-snapshot'), | ||
'no-capital-letters-in-routes': require('./rules/no-capital-letters-in-routes'), | ||
'no-duplicate-dependent-keys': require('./rules/no-duplicate-dependent-keys'), | ||
'no-empty-attrs': require('./rules/no-empty-attrs'), | ||
'no-function-prototype-extensions': require('./rules/no-function-prototype-extensions'), | ||
'no-global-jquery': require('./rules/no-global-jquery'), | ||
'no-jquery': require('./rules/no-jquery'), | ||
'no-observers': require('./rules/no-observers'), | ||
'no-old-shims': require('./rules/no-old-shims'), | ||
'no-on-calls-in-components': require('./rules/no-on-calls-in-components'), | ||
'no-side-effects': require('./rules/no-side-effects'), | ||
'order-in-components': require('./rules/order-in-components'), | ||
'order-in-controllers': require('./rules/order-in-controllers'), | ||
'order-in-models': require('./rules/order-in-models'), | ||
'order-in-routes': require('./rules/order-in-routes'), | ||
'require-super-in-init': require('./rules/require-super-in-init'), | ||
'routes-segments-snake-case': require('./rules/routes-segments-snake-case'), | ||
'use-brace-expansion': require('./rules/use-brace-expansion'), | ||
'use-ember-get-and-set': require('./rules/use-ember-get-and-set'), | ||
}, | ||
configs: { | ||
base: require('./config/base'), | ||
recommended: require('./config/recommended'), | ||
}, | ||
utils: { | ||
ember, | ||
utils, | ||
ember: require('./utils/ember'), | ||
utils: require('./utils/utils'), | ||
}, | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters