Skip to content

Commit

Permalink
Merge pull request #221 from 201-created/isaac/fix-main-service-lookup
Browse files Browse the repository at this point in the history
Fix Main Service Lookup
  • Loading branch information
mixonic committed Feb 13, 2018
2 parents b2357af + 9b5e679 commit 13f05eb
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 3 deletions.
1 change: 1 addition & 0 deletions mu-trees/addon/ember-config.js
Expand Up @@ -30,6 +30,7 @@ export default function generateConfig(name) {
serializer: { definitiveCollection: 'models' },
service: { definitiveCollection: 'services' },
template: { definitiveCollection: 'components' },
'template-options': { definitiveCollection: 'main' },
transform: { definitiveCollection: 'transforms' },
view: { definitiveCollection: 'views' },
'-view-registry': { definitiveCollection: 'main' },
Expand Down
2 changes: 1 addition & 1 deletion mu-trees/addon/module-registries/requirejs.js
Expand Up @@ -36,7 +36,7 @@ export default class RequireJSRegistry {
segments.push(s.namespace);
}

if (s.name !== 'main') {
if (s.name !== 'main' || s.collection !== 'main') {
segments.push(s.name);
}

Expand Down
8 changes: 6 additions & 2 deletions mu-trees/tests/unit/module-registries/requirejs-test.js
Expand Up @@ -60,7 +60,7 @@ module('RequireJS Registry', {
});

test('basic get', function(assert) {
assert.expect(8);
assert.expect(11);

[
/*
Expand All @@ -74,7 +74,11 @@ test('basic get', function(assert) {
[ 'template:/my-app/routes/components/my-input', 'my-app/src/ui/components/my-input/template' ],
[ 'template:/my-app/components/my-input', 'my-app/src/ui/components/my-input/template' ],
[ 'component:/my-app/components/my-input/my-button', 'my-app/src/ui/components/my-input/my-button/component' ],
[ 'template:/my-app/components/my-input/my-button', 'my-app/src/ui/components/my-input/my-button/template' ]
[ 'template:/my-app/components/my-input/my-button', 'my-app/src/ui/components/my-input/my-button/template' ],
[ 'service:/my-app/services/main', 'my-app/src/services/main' ],
[ 'component:/my-app/components/main', 'my-app/src/ui/components/main/component' ],
[ 'template:/my-app/components/main', 'my-app/src/ui/components/main/template' ],

]
.forEach(([ lookupString, expected ]) => {
let expectedModule = {};
Expand Down

0 comments on commit 13f05eb

Please sign in to comment.