Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 2.12 scenario from travis.yml #8024

Merged
merged 1 commit into from Sep 6, 2018

Conversation

cibernox
Copy link
Contributor

@cibernox cibernox commented Sep 6, 2018

In #8005 I removed 2.12 from config/ember-try.js but I forgot to remove it from the .travis.yml too.

@cibernox cibernox changed the title Don't disable jquery in 2.X scenarios [BUGFIX] Remove 2.12 scenario from travis.yml Sep 6, 2018
@cibernox
Copy link
Contributor Author

cibernox commented Sep 6, 2018

Can someone re-run the scenario that timed out?

@rwjblue rwjblue changed the base branch from beta to release September 6, 2018 12:40
@rwjblue
Copy link
Member

rwjblue commented Sep 6, 2018

This likely requires a 3.4.2, can you confirm?

Also, I updated to target release branch since I think #8005 landed in 3.4.x...

@cibernox
Copy link
Contributor Author

cibernox commented Sep 6, 2018

Yes, it does require a new patch release, otherwise running tests of a brand new addon will fail due to a missing scenario.

@rwjblue rwjblue merged commit bdd7d44 into ember-cli:release Sep 6, 2018
@Turbo87 Turbo87 added the bug label Sep 13, 2018
@Turbo87 Turbo87 changed the title [BUGFIX] Remove 2.12 scenario from travis.yml Remove 2.12 scenario from travis.yml Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants