Filter out blacklisted addons before calling included hook #7857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
approved these changes
Jun 11, 2018
|
this looks good to me. I've restarted the failing AppVeyor builds. Sorry for the long response time... 😞 |
Turbo87
changed the title
This was referenced Aug 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ember-enginescaches the host addons (theapp.project.addonslist) on the first addon hook callback, which isincluded. This is generally OK, except in the case whenEmberAppblacklists some of the addons.Because the list of the addons is actually filtered after the hook is called,
ember-enginesdeduplication algorithm is using the incorrect list of parent addons, because it has cached the list on the first hook call -included). This leads toember-enginesdeduplicating dependencies, which are not actually available in the app.