Support serving wasm with application/wasm #7670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fastest way to load wasm is WebAssembly.instantiateStreaming but it requires the mime-type to be correct. I can't update the mime module because it has engines >=6. I updated broccoli-middleware but have to manually define it for testem. (cherry picked from commit 43400c3)
|
There seems to be some yarn cache issue on Appveyor on one of the node versions in the matrix, I'm pretty sure this PR is good. |
This was referenced Mar 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #7664
The fastest way to load wasm is
WebAssembly.instantiateStreamingbut it requires the mime-type to be correct.I can't update the mime module because it has engines >=6.
I updated broccoli-middleware but have to manually define it for testem.
(cherry picked from commit 43400c3)