Addon#setupPreprocessorRegistry should be invoked after addon.app is set.

[stefanpenner]

• get feedback re: if this is reasonable (cc @rwjblue)
• tests (more comprehensive life-cycle tests)

[stefanpenner]

The more I look at this, the more reasonable it seems. Although im not 100% sure if pre-existing things depend on this ordering... its possible.

[stefanpenner]

Ya, so this ordering is depended on -> https://github.com/ember-cli/ember-cli-htmlbars-inline-precompile/blob/master/index.js#L71

But I believe we can at-least make app available before we call setupRegistry rather then after, which should ensure addon.app is available for setupPreprocessorRegistry (issue #6362)

[Turbo87]

@stefanpenner I'm not entirely following yet. what advantage does this create?

[stefanpenner]

@Turbo87 I'll write a test, that makes this more obvious but TL;DR addon.setupPreprocessorRegistry is invoked before addon.app is set, this means if you need access to addon.app.config for your registry setup your are out of luck today.

[stefanpenner]

fixed linting error.

[stefanpenner]

will change this to bugfix beta.

[rwjblue]

Updated to point to beta, and rebased.

[Turbo87]

thanks to mainmatter/ember-test-selectors#116 I finally understand what this PR is doing... LGTM 👍

[rwjblue]

Merging manually (changing targets makes @homu emo).

[Turbo87]

@stefanpenner it looks like the implementation here is somewhat flawed. for app builds this seems to work, but when building addons setupPreprocessorRegistry() is apparently called before the EmberApp/Addon class is even instantiated.

I'm trying to fix mainmatter/ember-test-selectors#345 but it seems almost impossible at this point. If you or @rwjblue have 30min to pair with me on this next week that would be awesome!