Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "ember-cli-htmlbars" #7038

Merged
merged 1 commit into from May 18, 2017
Merged

Update "ember-cli-htmlbars" #7038

merged 1 commit into from May 18, 2017

Conversation

stefanpenner
Copy link
Contributor

No description provided.

@stefanpenner stefanpenner requested a review from rwjblue May 11, 2017 22:48
@Turbo87
Copy link
Member

Turbo87 commented May 12, 2017

@stefanpenner why is this targeted at release? what bug is it fixing?

@stefanpenner
Copy link
Contributor Author

I believe it may address: emberjs/data#4947

I can target beta instead... would love your and @rwjblue's opinion.

@rwjblue
Copy link
Member

rwjblue commented May 14, 2017

Beta seems ok, but ultimately the ember data issue is resolved with an update in ember-data itself.

@stefanpenner
Copy link
Contributor Author

updated to beta

@Turbo87 Turbo87 changed the title [BUGFIX release] bump ember-cli-htmlbars [BUGFIX beta] bump ember-cli-htmlbars May 15, 2017
@Turbo87 Turbo87 changed the base branch from master to beta May 15, 2017 19:28
@Turbo87 Turbo87 changed the title [BUGFIX beta] bump ember-cli-htmlbars Update "ember-cli-htmlbars" May 15, 2017
@stefanpenner
Copy link
Contributor Author

stefanpenner commented May 15, 2017

after chatting with @rwjblue we should do this a release, as addons testing blueprints are affected.

@Turbo87
Copy link
Member

Turbo87 commented May 16, 2017

@stefanpenner it's still not clear to me what problem this is solving. can you elaborate on that?

@stefanpenner
Copy link
Contributor Author

@Turbo87 ember-cli/ember-cli-htmlbars#110 causes issues for addons testing blueprints. Ember-data ran into it.

If we upgrade ^ this goes away, We may also want to revert that PR. I can't remember what @rwjblue and me decided.. maybe he can refresh my memory.

@stefanpenner
Copy link
Contributor Author

@rwjblue apparently already reverted the ember-cli-htmlbars stuff. I'll switch this back to beta.

@Turbo87
Copy link
Member

Turbo87 commented May 17, 2017

ember-cli/ember-cli-htmlbars#110 is already included in v1.3.2 though, so not necessarily a need for the major bump 🤔

@Turbo87 Turbo87 merged commit f08a939 into beta May 18, 2017
@Turbo87 Turbo87 deleted the bump-ember-cli-htmlbars branch May 18, 2017 17:55
@Turbo87 Turbo87 added the bug label May 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants