New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update "ember-cli-htmlbars" #7038
Conversation
@stefanpenner why is this targeted at |
I believe it may address: emberjs/data#4947 I can target beta instead... would love your and @rwjblue's opinion. |
Beta seems ok, but ultimately the ember data issue is resolved with an update in ember-data itself. |
2ca8127
to
11103db
Compare
updated to beta |
11103db
to
1b7c4cc
Compare
1b7c4cc
to
f2d8da6
Compare
after chatting with @rwjblue we should do this a release, as addons testing blueprints are affected. |
@stefanpenner it's still not clear to me what problem this is solving. can you elaborate on that? |
@Turbo87 ember-cli/ember-cli-htmlbars#110 causes issues for addons testing blueprints. Ember-data ran into it. If we upgrade ^ this goes away, We may also want to revert that PR. I can't remember what @rwjblue and me decided.. maybe he can refresh my memory. |
@rwjblue apparently already reverted the ember-cli-htmlbars stuff. I'll switch this back to beta. |
ember-cli/ember-cli-htmlbars#110 is already included in v1.3.2 though, so not necessarily a need for the major bump 🤔 |
f2d8da6
to
2003ea2
Compare
No description provided.