Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXES #6970]: Revert nopt dependency update #6986

Merged
merged 2 commits into from Apr 28, 2017

Conversation

calderas
Copy link
Contributor

Revert nopt dependency update.
Adds a unit test to prevent updating to 4.x before it's fixed upstream.

Currently, 4.0.1 will fail

1) models/command.js parseArgs() should parse string options.:
   AssertionError: expected { Object (options, args) } to have a deep property 'options.options' of '--split 2 --random', but got ''
    at Context.<anonymous> (tests/unit/models/command-test.js:165:34)

Fixes #6970

@stefanpenner
Copy link
Contributor

stefanpenner commented Apr 27, 2017

@calderas awesome!

This looks like it has been an issue since v2.12.0 stable. As 2.13 is coming out shortly, we may want to try and get this in asap @Turbo87 mind evaluating or handling that?.

introduced: ff0b96e

@rwjblue
Copy link
Member

rwjblue commented Apr 27, 2017

Change the target branch of this PR to point at release, then it will be pulled in and ready for a 2.12 release. TBH I'm not sure if it is worth a separate 2.12.x when 2.13.0 is imminent...

@stefanpenner stefanpenner changed the base branch from master to release April 27, 2017 23:31
@stefanpenner stefanpenner changed the base branch from release to master April 27, 2017 23:32
@stefanpenner
Copy link
Contributor

stefanpenner commented Apr 27, 2017

TBH I'm not sure if it is worth a separate 2.12.x when 2.13.0 is imminent...

Sounds good.

@calderas do you mind changing the branch to release (likely requires a cherry pick). That way we can get it out in the 2.13 release.

@stefanpenner stefanpenner added this to the v2.13.0 milestone Apr 27, 2017
@calderas calderas changed the base branch from master to release April 28, 2017 00:33
@calderas calderas closed this Apr 28, 2017
@calderas calderas reopened this Apr 28, 2017
@calderas
Copy link
Contributor Author

Updated

@rwjblue rwjblue merged commit 279162f into ember-cli:release Apr 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants