ENHANCEMENT: throw when converting npm install foo to yarn install foo
#6966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n install foo` - throw when option.packages exists but neither options.save nor options['save-dev'] - test
|
LGTM. Thanks! @homu r+ |
|
📌 Commit 7d0ca1e has been approved by |
|
⚡ Test exempted - status |
homu
added a commit
that referenced
this pull request
Apr 19, 2017
ENHANCEMENT: throw when converting `npm install foo` to `yarn install foo` This was found while debugging a yarn related issue in Ember Electron. This was not very visible as most authors would probably include either the save or the save-dev flag, but as we had a typo in there in lead to an interesting bug hunt. `npm install foo` installs a package without saving it to package.json which is not an option in yarn (at least none that I know of). Therefore `yarn install foo` is no longer an equivalent command. This changed rather recently as `yarn` printed a deprecation warning pointing to `yarn add` before, but this is no longer the case in 0.23.2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was found while debugging a yarn related issue in Ember Electron. This was not very visible as most authors would probably include either the save or the save-dev flag, but as we had a typo in there in lead to an interesting bug hunt.
npm install fooinstalls a package without saving it to package.json which is not an option in yarn (at least none that I know of). Thereforeyarn install foois no longer an equivalent command.This changed rather recently as
yarnprinted a deprecation warning pointing toyarn addbefore, but this is no longer the case in 0.23.2.