Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

various blueprint cleanup and consistency #6937

Merged
merged 1 commit into from Apr 2, 2017
Merged

various blueprint cleanup and consistency #6937

merged 1 commit into from Apr 2, 2017

Conversation

kellyselden
Copy link
Member

whitespace consistency and use strict and eslint-env ordering consistency.

@twokul twokul merged commit e087db6 into ember-cli:master Apr 2, 2017
@kellyselden kellyselden deleted the blueprint-cleanup branch April 2, 2017 22:47
@homu homu mentioned this pull request Apr 2, 2017
Merged
Turbo87
Turbo87 reviewed May 2, 2017
View reviewed changes
blueprints/addon/files/ember-cli-build.js
/* eslint-env node */
'use strict';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't the strict directive be the top-most thing in the file?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue left review comments

@Turbo87 Turbo87 Turbo87 left review comments

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kellyselden @rwjblue @Turbo87 @twokul