Run YUIDoc on single it
#6915
Merged
Run YUIDoc on single it
#6915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
requested changes
Mar 28, 2017
There was a problem hiding this comment.
I think instead of the changes in this PR we should change https://github.com/ember-cli/ember-cli/blob/master/tests/unit/docs-lint-test.js to execute yuiDoc.run() inside of a single it() block and not generate one it() block per file which is currently causing the issue.
sduquej
force-pushed
the
no-yuidoc-on-glob
branch
3 times, most recently
from
85902ce
to
ac7ea10
Compare
sduquej
changed the title
it
sduquej
force-pushed
the
no-yuidoc-on-glob
branch
from
ac7ea10
to
2f3f1eb
Compare
sduquej
force-pushed
the
no-yuidoc-on-glob
branch
from
2f3f1eb
to
80028dd
Compare
|
@homu r+ |
|
📌 Commit 80028dd has been approved by |
|
⚡ Test exempted - status |
homu
added a commit
that referenced
this pull request
Apr 17, 2017
Run YUIDoc on single `it` Second part of #6565 Currently we lint docs even when explicitly passing a glob for specific files. This PR changes that behaviour, skipping doc linting in that case and keeping it for the `all` and `lint` options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second part of #6565
Currently we lint docs even when explicitly passing a glob for specific files. This PR changes that behaviour, skipping doc linting in that case and keeping it for the
allandlintoptions