[BUGFIX] Add yuidocs for the addon:init method #6910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattmarcum
changed the title
Turbo87
requested changes
Mar 27, 2017
| @public | ||
| @method init | ||
| @param {Project|Addon} parent The project or addon that directly depends on this addon | ||
| @param {Project} project The current project (deprecated) |
There was a problem hiding this comment.
could you add an @example for this method? I think the this._super() call should actually include the arguments too (e.g. like in https://github.com/babel/ember-cli-babel/blob/4ab3d4a0929c6a4c9420a7bd6c15ed24f6d976f6/index.js#L23)
There was a problem hiding this comment.
ok, I used argument destructuring.
There was a problem hiding this comment.
I think argument destructuring is not available on Node 4 though, and since we don't run Ember CLI itself through Babel we can't use it yet.
Turbo87
requested changes
Mar 28, 2017
lib/models/addon.js
Outdated
| this._super(parent, project); | ||
| this._someCustomSetup(); | ||
| } | ||
| ``` |
There was a problem hiding this comment.
could you change the example to:
init() {
this._super.init && this._super.init.apply(this, arguments);
this._someCustomSetup();
}
|
awesome, thanks. could you squash the commits? |
Turbo87
approved these changes
Mar 28, 2017
mattmarcum
force-pushed
the
6780-docuement-addon-init-method
branch
from
07175a0
to
ec68d39
Compare
|
squashed |
|
muchas gracias! @homu r+ |
|
📌 Commit ec68d39 has been approved by |
homu
added a commit
that referenced
this pull request
Mar 28, 2017
…Turbo87 [BUGFIX] Add yuidocs for the addon:init method Addresses [6780](#6780) Just starting the documentation process. Let me know if there's any other relevant info to add in here.
|
☀️ Test successful - status |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses 6780
Just starting the documentation process. Let me know if there's any other relevant info to add in here.