remove npm experiment refs #6903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IMHO we should test drive that at least until a couple of days after EmberConf before actually removing the feature flag. essentially we're not in any rush since the next branch point is still a few weeks out. |
|
@Turbo87 - Yep, agreed. We should hold off on landing this for a week or two. @tylerturdenpants - Thanks for taking the time and submitting the PR! |
|
We discussed at yesterdays ember-cli meeting, and are 👍 on moving this forward. There has been quite a bit of real world testing/usage (mostly with |
|
@homu r+ |
|
📌 Commit fe5ebea has been approved by |
homu
added a commit
that referenced
this pull request
Apr 7, 2017
remove npm experiment refs Per issue description, removed and refactored npm experiment references resolves #6900
|
☀️ Test successful - status |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per issue description, removed and refactored npm experiment references
resolves #6900