Handle addon constructor errors gracefully

[jsturgis]

This change adds a user friendly error message when an addon constructor
function throws an error during addon initialization.

Fixes #6820

[rwjblue]

Looks really good, thanks for working on this!

One thought that I had was that we may want to also wrap the Addon.lookup line as well (but keep track of which one errors). That Addon.lookup just above is where we require the actual addon module (here), so we could provide nicer errors for both scenarios:

• An error occured in the constructor for ${addonInfo.name} at ${addonInfo.path}
• An error occured while requiring ${addonInfo.name} at ${addonInfo.path}

What do you think?

[jsturgis]

Thanks! I think that sounds like a good idea but I noticed that Addon.lookup is already handling the most common error case here and I can't think of another error case that could happen in lookup that it isn't already checking for.

[rwjblue]

Seems good, thanks for checking into it!

@homu r+

[homu]

📌 Commit 1de03e3 has been approved by rwjblue

[homu]

⌛ Testing commit 1de03e3 with merge f2acf6e...

[homu]

☀️ Test successful - status