Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broccoli/ember-app: Make app/index.html optional #6883

Merged
merged 1 commit into from Mar 25, 2017

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Mar 21, 2017

Resolves #6825 (comment)

/cc @iezer

@Turbo87 Turbo87 added the bug label Mar 21, 2017
@Turbo87 Turbo87 requested a review from rwjblue March 21, 2017 18:55
@iezer
Copy link
Contributor

iezer commented Mar 21, 2017

@Turbo87 Thanks!

@rwjblue
Copy link
Member

rwjblue commented Mar 25, 2017

@homu r+

@homu
Copy link
Contributor

homu commented Mar 25, 2017

📌 Commit 8bcb5f7 has been approved by rwjblue

homu added a commit that referenced this pull request Mar 25, 2017
broccoli/ember-app: Make app/index.html optional

Resolves #6825 (comment)

/cc @iezer
@homu
Copy link
Contributor

homu commented Mar 25, 2017

⌛ Testing commit 8bcb5f7 with merge 0f5260e...

@homu
Copy link
Contributor

homu commented Mar 25, 2017

☀️ Test successful - status

@homu homu merged commit 8bcb5f7 into ember-cli:master Mar 25, 2017
@Turbo87 Turbo87 deleted the index-html branch March 26, 2017 07:40
@iezer
Copy link
Contributor

iezer commented Mar 27, 2017

@Turbo87 Found a related, unfortunate, bug. If you make an addon for example ember-resolver, it won't build because it doesn't have a file in src/ui/index.html :( Solution is to create an empty file.

@rwjblue
Copy link
Member

rwjblue commented Mar 27, 2017

@iezer - @mixonic and I spiked on a bunch of src related build issues this afternoon, he should be pushing up a branch that you can track soon...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants