Add .eslintrc.js files to blueprints #6874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The node@4 job failed for flaky timeout reasons, restarted it... |
rwjblue
approved these changes
Mar 20, 2017
|
@homu r+ |
|
📌 Commit 7443943 has been approved by |
|
⚡ Test exempted - status |
homu
added a commit
that referenced
this pull request
Mar 20, 2017
Add .eslintrc.js files to blueprints Fixes #6864
|
grr, looks like homu merged master anyways 😢 |
|
@rwjblue yeah, homu doesn't work with changing the base branch of the PR after it has been opened |
|
@rwjblue @rwwagner90 since ESLint got introduced in 2.12 I think it would make sense to pull this down to the |
|
Sure, seems good to me. |
This was referenced Mar 21, 2017
homu
added a commit
that referenced
this pull request
Mar 21, 2017
Add .eslintrc.js files to blueprints backport of #6874 for v2.12.1 /cc @rwwagner90
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6864