Ensure beforeRun is included in command instrumentation.
#6628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calling `beforeEach` / `afterEach` like this these blocks are ran for **every** test in **all** files. That is **_bad_**!
Prior to this change `command.beforeRun` was being included in `init` instrumentation. This change fixes that by moving `.beforeRun` into `command` instrumentation. This change also ensures that `beforeRun` can return a promise (which we had previously documented in the API docs but was not actually supported until this commit) and adds a test.
Turbo87
approved these changes
Jan 1, 2017
|
@homu r+ |
|
📌 Commit 13faa4a has been approved by |
homu
added a commit
that referenced
this pull request
Jan 1, 2017
Ensure `beforeRun` is included in `command` instrumentation. Prior to this change `command.beforeRun` was being included in `init` instrumentation. This change fixes that by moving `.beforeRun` into `command` instrumentation. This change also ensures that `beforeRun` can return a promise (which we had previously documented in the API docs but was not actually supported until this commit) and adds a test.
|
☀️ Test successful - status |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change
command.beforeRunwas being included ininitinstrumentation. This change fixes that by moving.beforeRunintocommandinstrumentation.This change also ensures that
beforeRuncan return a promise (which we had previously documented in the API docs but was not actually supported until this commit) and adds a test.