Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version of ember-cli-eslint used in new applications. #6624

Merged
merged 1 commit into from Jan 1, 2017

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Jan 1, 2017

New applications will now get ember-cli-eslint@3 which uses the latest version of eslint (we previously could not do this update due to eslint@3 dropping support for Node 0.12).

New applications will now get ember-cli-eslint@3 which uses the latest
version of eslint (we previously could not do this update due to eslint@3
dropping support for Node 0.12).
@rwjblue
Copy link
Member Author

rwjblue commented Jan 1, 2017

@homu r+

@homu
Copy link
Contributor

homu commented Jan 1, 2017

📌 Commit d09f10e has been approved by rwjblue

@homu
Copy link
Contributor

homu commented Jan 1, 2017

⚡ Test exempted - status

@homu homu merged commit d09f10e into ember-cli:master Jan 1, 2017
homu added a commit that referenced this pull request Jan 1, 2017
Update version of ember-cli-eslint used in new applications.

New applications will now get ember-cli-eslint@3 which uses the latest version of eslint (we previously could not do this update due to eslint@3 dropping support for Node 0.12).
@rwjblue rwjblue deleted the update-ember-cli-eslint branch January 1, 2017 17:52
@nathanhammond
Copy link
Contributor

Given more time to think about it, I'm not 100% happy with how ember-cli-eslint isn't in the default blueprint anymore. Many users don't use ember init to handle upgrades which means that they end up "stuck" on whichever version they have installed, or worse, delete it without paying attention as to why when they view the comparison.

This whole setup exists for one reason: we need to be able to run all default blueprints for bundled addons once per application creation. We possibly want to run the default blueprint for every addon in the application each time that addon gets updated. But we can't run that blueprint unless we actually have a node_modules folder. This complicates programmatic fixture creation as well.

/cc @Turbo87

@Turbo87
Copy link
Member

Turbo87 commented Jan 5, 2017

@nathanhammond I'm open to other suggestions...

@Turbo87 Turbo87 added this to the v2.12.0 milestone Jan 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants