Expose status codes on error objects

There may be cases where callers want access to the status code that caused the error (e.g. logging/metrics, or terse user-facing error messages), so this allows them to easily get at it.
ember-cli · Nov 30, 2017 · 25f4e55 · 25f4e55
1 parent c92d9a7
commit 25f4e55
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/addon/mixins/ajax-request.js b/addon/mixins/ajax-request.js
@@ -551,6 +551,7 @@ export default Mixin.create({
 
       error = new AjaxError(payload, detailedMessage);
     }
+    error.status = status;
 
     return error;
   },

diff --git a/tests/unit/mixins/ajax-request-test.js b/tests/unit/mixins/ajax-request-test.js
@@ -570,6 +570,7 @@ describe('Unit | Mixin | ajax request', function() {
         expect(result.message).to.contain('Some error response');
         expect(result.message).to.contain('GET');
         expect(result.message).to.contain('/posts');
+        expect(result.status).to.equal(408);
       });
   });
 
@@ -587,6 +588,7 @@ describe('Unit | Mixin | ajax request', function() {
         expect(result.message).to.contain('Some error response');
         expect(result.message).to.contain('GET');
         expect(result.message).to.contain('/posts');
+        expect(result.status).to.equal(408);
       });
   });
 
@@ -883,6 +885,7 @@ describe('Unit | Mixin | ajax request', function() {
         .catch(function(reason) {
           expect(isTimeoutError(reason)).to.be.ok;
           expect(reason.payload).to.be.null;
+          expect(reason.status).to.be.undefined;
         });
     });
 
@@ -901,6 +904,7 @@ describe('Unit | Mixin | ajax request', function() {
           .catch(function(reason) {
             expect(reason instanceof errorClass).to.be.ok;
             expect(reason.payload).to.not.be.undefined;
+            expect(reason.status).to.equal(status);
 
             const { errors } = reason.payload;