Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: actually return appmetrics in 3-0-x #14750

Merged
merged 1 commit into from Sep 21, 2018
Merged

Conversation

MarshallOfSound
Copy link
Member

@MarshallOfSound MarshallOfSound commented Sep 21, 2018

Fixes #14710

Notes: fix app.getAppMetrics returning undefined in 3.0.0

@MarshallOfSound MarshallOfSound requested a review from a team September 21, 2018 08:01
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

How on earth did this pass CI before

@ckerr ckerr added this to PR in Flight in 3.0.x / 3.1.x Sep 21, 2018
@ckerr ckerr removed this from PR in Flight in 3.0.x / 3.1.x Sep 21, 2018
@ckerr ckerr merged commit db03841 into 3-0-x Sep 21, 2018
@release-clerk
Copy link

release-clerk bot commented Sep 21, 2018

Release Notes Persisted

fix app.getAppMetrics returning undefined

@ckerr ckerr deleted the MarshallOfSound-patch-1 branch September 21, 2018 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants