Merge explicit and inferred param defaults (#1230)

documentationjs · Apr 18, 2019 · d1ee0f3 · d1ee0f3
1 parent 03e721f
commit d1ee0f3
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 1 deletion.
diff --git a/__tests__/lib/infer/__snapshots__/params.js.snap b/__tests__/lib/infer/__snapshots__/params.js.snap
@@ -217,6 +217,21 @@ Array [
 ]
 `;
 
+exports[`inferParams 8`] = `
+Array [
+  Object {
+    "default": "4",
+    "lineNumber": 1,
+    "name": "x",
+    "title": "param",
+    "type": Object {
+      "name": "number",
+      "type": "NameExpression",
+    },
+  },
+]
+`;
+
 exports[`mergeTrees 1`] = `
 Object {
   "errors": Array [

diff --git a/__tests__/lib/infer/params.js b/__tests__/lib/infer/params.js
@@ -191,4 +191,15 @@ test('inferParams', function() {
       }
     `).params
   ).toEqual([]);
+
+  expect(
+    evaluate(
+      `
+    /** Test
+     * @param x
+    */
+    function f(x: number = 4) {}
+  `
+    ).params
+  ).toMatchSnapshot();
 });
diff --git a/src/infer/params.js b/src/infer/params.js
@@ -338,7 +338,9 @@ function combineTags(inferredTag, explicitTag) {
   let defaultValue;
   if (!explicitTag.type) {
     type = inferredTag.type;
-  } else if (!explicitTag.default && inferredTag.default) {
+  }
+
+  if (!explicitTag.default && inferredTag.default) {
     defaultValue = inferredTag.default;
   }