fix: cover more hideconstructor cases

documentationjs · Sep 4, 2017 · 5bdbf1f · 5bdbf1f
1 parent 0307dba
commit 5bdbf1f
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 2 deletions.
diff --git a/__tests__/lib/parsers/javascript.js b/__tests__/lib/parsers/javascript.js
@@ -84,3 +84,24 @@ test('parse - document exported', function() {
     ).length
   ).toBe(2);
 });
+
+test('parse - constructor comments', function() {
+  expect(
+    toComments(`
+      class Test {
+        /** @hideconstructor */
+        constructor() {}
+      }
+    `).length
+  ).toBe(0);
+
+  expect(
+    toComments(`
+      /** Test */
+      export class Test {
+        /** @hideconstructor */
+        constructor() {}
+      }
+    `)[0].constructorComment
+  ).toBeDefined();
+});
diff --git a/src/parsers/javascript.js b/src/parsers/javascript.js
@@ -6,7 +6,8 @@ var _ = require('lodash'),
   walkComments = require('../extractors/comments'),
   walkExported = require('../extractors/exported'),
   util = require('util'),
-  debuglog = util.debuglog('documentation');
+  debuglog = util.debuglog('documentation'),
+  findTarget = require('../infer/finders').findTarget;
 
 import { parseToAst } from './parse_to_ast';
 
@@ -98,7 +99,7 @@ function _addComment(
     }
     const comment = parse(commentValue, commentLoc, context);
     if (includeContext) {
-      commentsByNode.set(path.node, comment);
+      commentsByNode.set((findTarget(path) || path).node, comment);
 
       if (t.isClassMethod(path) && path.node.kind === 'constructor') {
         // #689
@@ -115,6 +116,9 @@ function _addComment(
           parentComment.constructorComment = comment;
           return;
         }
+        if (comment.hideconstructor) {
+          return;
+        }
       }
     }
     return comment;