Reorganize and improve render unit tests #1199
Conversation
| @@ -151,12 +151,6 @@ describe('Components', () => { | |||
| expect(scratch.innerHTML).to.equal(''); | |||
| }); | |||
|
|
|||
| // Test for #651 | |||
| it('should set enumerable boolean attribute', () => { | |||
There was a problem hiding this comment.
I just moved this into the render.js UT file since this test doesn't actually use an components
| }); | ||
| }); | ||
|
|
||
| describe('event handling', () => { |
There was a problem hiding this comment.
I grouped all event handling under a common describe block
There was a problem hiding this comment.
I also broke up the event handling tests to better specify the various concerns they were testing
There was a problem hiding this comment.
Yay, meaningful failure messages!
| .that.matches(/top\s*:\s*5px\s*/) | ||
| .and.matches(/position\s*:\s*relative\s*/); | ||
| }); | ||
| describe('style attribute', () => { |
There was a problem hiding this comment.
Moved all style tests under a common describe block
| } | ||
| render(props, { html }) { | ||
| return html ? <div dangerouslySetInnerHTML={{ __html: html }} /> : <div />; | ||
| describe('dangerouslySetInnerHTML', () => { |
There was a problem hiding this comment.
Group all dangerouslySetInnerHTML tests under a common describe block
| { todos.map( todo => (<div>{todo.text}</div> )) } | ||
| <div onKeyDown={this.addTodo}> | ||
| { todos.map( todo => ([ | ||
| <span>{todo.text}</span>, |
There was a problem hiding this comment.
The original issue called out this example as a better test for this test case so I updated the test to cover this.
| it('should only register on* functions as handlers', () => { | ||
| let click = () => {}, | ||
| onclick = () => {}; | ||
| it('should properly switch from string styles to object styles and back', () => { |
There was a problem hiding this comment.
we'll want to revisit this if we decide to remove string style support (it's a preact-only feature)
| }); | ||
| }); | ||
|
|
||
| describe('event handling', () => { |
There was a problem hiding this comment.
Yay, meaningful failure messages!
| @@ -588,44 +699,69 @@ describe('render()', () => { | |||
| expect(sortAttributes(html)).to.equal(sortAttributes('<input type="range" min="0" max="100" list="steplist">')); | |||
| }); | |||
|
|
|||
| it('should not execute append operation when child is at last', (done) => { | |||
| it('should not execute append operation when child is at last', () => { | |||
| // See developit/preact#717 for discussion about the issue this addresses | |||
There was a problem hiding this comment.
👍 I wish I'd left more of these issue references around.
There was a problem hiding this comment.
side note: we should totally look into reusing this component + plumbing for a bunch of different tests.
|
Approved x1000 |
Reorganize render unit tests to better represent the expectations that the test are validating. Also, improved a couple tests to better cover their scenario.