Fix cloneElement Typescript definition #1197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cloneElement function accepts an optional third argument to override the cloned element's children.
marvinhagemeister
requested changes
Aug 25, 2018
src/preact.d.ts
Outdated
| @@ -114,7 +114,7 @@ declare namespace preact { | |||
|
|
|||
| function render(node: ComponentChild, parent: Element | Document | ShadowRoot | DocumentFragment, mergeWith?: Element): Element; | |||
| function rerender(): void; | |||
| function cloneElement(element: JSX.Element, props: any): JSX.Element; | |||
| function cloneElement(element: JSX.Element, props: any, children?: ComponentChildren): JSX.Element; | |||
There was a problem hiding this comment.
That should be a rest argument like ...children
marvinhagemeister
approved these changes
Aug 25, 2018
|
Thank you for your feedback and work on this great library! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the optional third argument to the cloneElement function's Typescript definition.