Inline setProperty function #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvinhagemeister
approved these changes
May 27, 2018
src/dom/index.js
Outdated
| // Attempt to set a DOM property to the given value. | ||
| // IE & FF throw for certain property-value combinations. | ||
| try { | ||
| node[name] = value==null ? '' : value; |
There was a problem hiding this comment.
Two spaces or a tab after the equals sign :)
There was a problem hiding this comment.
Whoops - amended my commit with the fix
Inlining the setProperty function (which is only used once) saves 7 bytes.
andrewiggins
force-pushed
the
inline-set-property
branch
from
517ef31
to
1ae6f88
Compare
|
Thanks again for your contribution 🎉 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inlining the setProperty function (which is only used once) saves 7 bytes. Thought I could try to pay back some of the bytes of new features that have gone into Preact recently.