New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove import pruning #265
Conversation
@@ -291,19 +290,6 @@ function createConfig(options, entry, format, writeMeta) { | |||
let nameCache = {}; | |||
let mangleOptions = options.pkg.mangle || false; | |||
|
|||
let exportType; | |||
if (format !== 'es') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we make it an option instead of deleting?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could put this code behind an option. In either case it needs to be disabled for TypeScript because this breaks the generated typing definitions.
bors try |
I just tested this out and it seems to work just fine. It'd be great to get this merged and released. It's pretty critical for the usage of the library. |
I turned on branch protection so now we get the "update branch" button. |
this new fork includes: - developit/microbundle#271 - developit/microbundle#268 - developit/microbundle#265 these changes are planned to be merged upstream anytime soon
bors r+ |
Canceled |
bors retry |
265: Remove import pruning r=ForsakenHarmony a=marvinhagemeister Fixes #264 **EDIT:** PR #262 likely needs to be merged first, as that one fixes the failing CI. Co-authored-by: Marvin Hagemeister <marvin@marvinhagemeister.de> Co-authored-by: Jason Miller <developit@users.noreply.github.com> Co-authored-by: Leah <me@hrmny.sh>
Build succeeded |
32: Update microbundle to the latest version 🚀 r=ForsakenHarmony a=greenkeeper[bot] ## The devDependency [microbundle](https://github.com/developit/microbundle) was updated from `0.8.4` to `0.9.0`. This version is **not covered** by your **current version range**. If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update. --- <details> <summary>Release Notes for 0.9.0</summary> <h3>Breaking Changes</h3> <ul> <li>Remove import pruning: <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="387476865" data-permission-text="Issue title is private" data-url="developit/microbundle#265" data-hovercard-type="pull_request" data-hovercard-url="/developit/microbundle/pull/265/hovercard" href="https://urls.greenkeeper.io/developit/microbundle/pull/265">#265</a> (thx <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=1062408" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://urls.greenkeeper.io/marvinhagemeister">@marvinhagemeister</a> <g-emoji class="g-emoji" alias="heart" fallback-src="https://github.githubassets.com/images/icons/emoji/unicode/2764.png">❤️</g-emoji>)</li> </ul> <p>(also added bors to not break master)</p> </details> <details> <summary>Commits</summary> <p>The new version differs by 9 commits.</p> <ul> <li><a href="https://urls.greenkeeper.io/developit/microbundle/commit/e1fbcc7e6b94aa9a58ca797cd80faebf0eccd689"><code>e1fbcc7</code></a> <code>0.9.0</code></li> <li><a href="https://urls.greenkeeper.io/developit/microbundle/commit/bd77b1200bd5cf9205376985e5881bf973f91ba5"><code>bd77b12</code></a> <code>Merge #265</code></li> <li><a href="https://urls.greenkeeper.io/developit/microbundle/commit/2dd10e5a1f3eceb34193b82244232521033bf809"><code>2dd10e5</code></a> <code>Merge branch 'master' into remove_import_pruning</code></li> <li><a href="https://urls.greenkeeper.io/developit/microbundle/commit/0013f24e9a8bcfdc4f12800d16e4c1393e9ca361"><code>0013f24</code></a> <code>Merge #267</code></li> <li><a href="https://urls.greenkeeper.io/developit/microbundle/commit/69211a316610d70bd9417ab1077e04a36166cae4"><code>69211a3</code></a> <code>Merge pull request #278 from developit/0.8.4</code></li> <li><a href="https://urls.greenkeeper.io/developit/microbundle/commit/79501af4fffbe8dfeabd65efbb8425ea62c4fff8"><code>79501af</code></a> <code>Create bors.toml</code></li> <li><a href="https://urls.greenkeeper.io/developit/microbundle/commit/bcefac62102332811df25c6036939325523f8840"><code>bcefac6</code></a> <code>Exceptions for bors</code></li> <li><a href="https://urls.greenkeeper.io/developit/microbundle/commit/296026b0654427ecf917841d10892bf482cc73c0"><code>296026b</code></a> <code>Merge branch 'master' into remove_import_pruning</code></li> <li><a href="https://urls.greenkeeper.io/developit/microbundle/commit/3176b69754562a1e1913ca4d2917a8ebb79a972d"><code>3176b69</code></a> <code>Remove import pruning</code></li> </ul> <p>See the <a href="https://urls.greenkeeper.io/developit/microbundle/compare/391800a88cb7dc6aeb57d97e7d783112e3ad0206...e1fbcc7e6b94aa9a58ca797cd80faebf0eccd689">full diff</a></p> </details> <details> <summary>FAQ and help</summary> There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new). </details> --- Your [Greenkeeper](https://greenkeeper.io) bot 🌴 Co-authored-by: greenkeeper[bot] <greenkeeper[bot]@users.noreply.github.com>
this new fork includes: - developit/microbundle#271 - developit/microbundle#268 - developit/microbundle#265 these changes are planned to be merged upstream anytime soon
Fixes #264
EDIT: PR #262 likely needs to be merged first, as that one fixes the failing CI.