Skip to content

Commit

Permalink
Merge #324
Browse files Browse the repository at this point in the history
324: Move Rollup 'treeshake' value to be a part of inputOptions r=ForsakenHarmony a=jviide

This pull request moves the `treeshake` value that is passed to Rollup. Based on [the documentation](https://rollupjs.org/guide/en#inputoptions) it should be a part of the `inputOptions` object instead of `outputOptions`.

Co-authored-by: Joachim Viide <jviide@iki.fi>
  • Loading branch information
bors[bot] and jviide committed Feb 23, 2019
2 parents 65730af + b1f16b3 commit 4ef32f1
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/index.js
Expand Up @@ -418,6 +418,9 @@ function createConfig(options, entry, format, writeMeta) {
}
return externalTest(id);
},
treeshake: {
propertyReadSideEffects: false,
},
plugins: []
.concat(
postcss({
Expand Down Expand Up @@ -592,9 +595,6 @@ function createConfig(options, entry, format, writeMeta) {
freeze: false,
esModule: false,
sourcemap: options.sourcemap,
treeshake: {
propertyReadSideEffects: false,
},
format,
name: options.name,
file: resolve(
Expand Down

0 comments on commit 4ef32f1

Please sign in to comment.