Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(layout-table): deprecate layout-table rule and checks #1885

Merged
merged 1 commit into from
Nov 7, 2019
Merged

feat(layout-table): deprecate layout-table rule and checks #1885

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/rule-descriptions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
| landmark-no-duplicate-contentinfo | Ensures the document has at most one contentinfo landmark | Moderate | cat.semantics, best-practice | true |
| landmark-one-main | Ensures the document has only one main landmark and each iframe in the page has at most one main landmark | Moderate | cat.semantics, best-practice | true |
| landmark-unique | Landmarks must have a unique role or role/label/title (i.e. accessible name) combination | Moderate | cat.semantics, best-practice | true |
| layout-table | Ensures presentational <table> elements do not use <th>, <caption> elements or the summary attribute | Serious | cat.semantics, wcag2a, wcag131 | true |
| layout-table | Ensures presentational <table> elements do not use <th>, <caption> elements or the summary attribute | Serious | cat.semantics, wcag2a, wcag131, deprecated | false |
| link-in-text-block | Links can be distinguished without relying on color | Serious | cat.color, experimental, wcag2a, wcag141 | true |
| link-name | Ensures links have discernible text | Serious | cat.name-role-value, wcag2a, wcag412, wcag244, section508, section508.22.a | true |
| list | Ensures that lists are structured correctly | Serious | cat.structure, wcag2a, wcag131 | true |
Expand Down
1 change: 1 addition & 0 deletions lib/checks/tables/has-caption.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"id": "has-caption",
"evaluate": "has-caption.js",
"deprecated": true,
"metadata": {
"impact": "serious",
"messages": {
Expand Down
1 change: 1 addition & 0 deletions lib/checks/tables/has-summary.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"id": "has-summary",
"evaluate": "has-summary.js",
"deprecated": true,
"metadata": {
"impact": "serious",
"messages": {
Expand Down
1 change: 1 addition & 0 deletions lib/checks/tables/has-th.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"id": "has-th",
"evaluate": "has-th.js",
"deprecated": true,
"metadata": {
"impact": "serious",
"messages": {
Expand Down
3 changes: 2 additions & 1 deletion lib/rules/layout-table.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,12 @@
"id": "layout-table",
"selector": "table",
"matches": "layout-table-matches.js",
"tags": ["cat.semantics", "wcag2a", "wcag131"],
"tags": ["cat.semantics", "wcag2a", "wcag131", "deprecated"],
"metadata": {
"description": "Ensures presentational <table> elements do not use <th>, <caption> elements or the summary attribute",
"help": "Layout tables must not use data table elements"
},
"enabled": false,
"all": [],
"any": [],
"none": ["has-th", "has-caption", "has-summary"]
Expand Down