Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(page-has-main): ignore hidden elements #2001

Merged
merged 1 commit into from Jan 29, 2020
Merged

fix(page-has-main): ignore hidden elements #2001

merged 1 commit into from Jan 29, 2020

Conversation

straker
Copy link
Contributor

@straker straker commented Jan 27, 2020 •
edited by WilcoFiers

In the same vain as #1973, if a page has a main or h1 element but it is not visible, it shouldn't pass the check.

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@straker straker requested a review from a team as a code owner January 27, 2020 21:38
@WilcoFiers WilcoFiers changed the title fix(page-has-main): do not find hidden elements fix(page-has-main): ignore empty pages Jan 29, 2020
@WilcoFiers WilcoFiers changed the title fix(page-has-main): ignore empty pages fix(page-has-main): ignore hidden elements Jan 29, 2020
@straker straker added this to the Axe-core 3.5 milestone Jan 29, 2020
@straker straker merged commit 6429e60 into develop Jan 29, 2020
@straker straker deleted the pageHasHidden branch January 29, 2020 17:38
@straker straker mentioned this pull request Feb 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilcoFiers WilcoFiers WilcoFiers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Axe-core 3.5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@straker @WilcoFiers